[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[openssl-gost] [gost-engine/engine] af2028: Fix gcc13 error: writing 1 byte into a region of s...
Branch: refs/heads/master
Home: https://github.com/gost-engine/engine
Commit: af20283d945d0607c2245e7f5871ee09c9024bc0
https://github.com/gost-engine/engine/commit/af20283d945d0607c2245e7f5871ee09c9024bc0
Author: Vitaly Chikunov <vt@altlinux.org>
Date: 2023-06-15 (Thu, 15 Jun 2023)
Changed paths:
M gost_omac_acpkm.c
Log Message:
-----------
Fix gcc13 error: writing 1 byte into a region of size 0
gcc-13 thinks `bl` can take negative value (when returned from
EVP_CIPHER_CTX_block_size). Do simple sanity checking to workaround this.
Also, add error propagation up to EVP_DigestFinal_ex, so this sanity checking
is not in vain.
Error message:
In function 'make_kn',
inlined from 'CMAC_ACPKM_Final' at /builddir/build/BUILD/engine-3.0.0/gost_omac_acpkm.c:274:5,
inlined from 'omac_acpkm_imit_final' at /builddir/build/BUILD/engine-3.0.0/gost_omac_acpkm.c:354:5:
/builddir/build/BUILD/engine-3.0.0/gost_omac_acpkm.c:55:20: error: writing 1 byte into a region of size 0 [-Werror=stringop-overflow=]
55 | k1[bl - 1] ^= bl == 16 ? 0x87 : 0x1b;
| ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
/builddir/build/BUILD/engine-3.0.0/gost_omac_acpkm.c: In function 'omac_acpkm_imit_final':
/builddir/build/BUILD/engine-3.0.0/gost_omac_acpkm.c:260:24: note: at offset [-2147483649, -1] into destination object 'k2' of size 32
260 | unsigned char *k1, k2[EVP_MAX_BLOCK_LENGTH];
| ^~
Fixes: https://github.com/gost-engine/engine/issues/436
Signed-off-by: Vitaly Chikunov <vt@altlinux.org>