[openssl-gost] [FYI] fbinfer on gost-engine

[Vitaly Chikunov <vt@altlinux.org>]

Hi,

Попробовал статический анализатор fb infer на gost-engine, вот
что вылезло:


Found 4 issues

gostsum.c:165: error: RESOURCE_LEAK
  resource acquired by call to `open()` at line 160, column 15 is not released after line 165, column 16.
  163.       }
  164.       if (!hash_stream(ctx, fd, sum)) {
  165. >         perror(filename);
  166.           return 0;
  167.       }

gost_ec_keyx.c:252: error: DEAD_STORE
  The value written to &key_is_ephemeral (type int) is never used.
  250.       unsigned char ukm[8], shared_key[32], crypted_key[44];
  251.       int ret = 0;
  252. >     int key_is_ephemeral = 1;
  253.       gost_ctx cctx;
  254.       EVP_PKEY *sec_key = EVP_PKEY_CTX_get0_peerkey(pctx);

gost_ameth.c:351: error: DEAD_STORE
  The value written to &expected_key_len (type int) is never used.
  349.       const ASN1_OBJECT *palg_obj = NULL;
  350.       ASN1_INTEGER *priv_key = NULL;
  351. >     int expected_key_len = 32;
  352.
  353.       if (!PKCS8_pkey_get0(&palg_obj, &pkey_buf, &priv_len, &palg, p8inf))

gost_ameth.c:722: error: DEAD_STORE
  The value written to &ptype (type int) is never used.
  720.       BIGNUM *X = NULL, *Y = NULL, *order = NULL;
  721.       const EC_KEY *ec = EVP_PKEY_get0((EVP_PKEY *)pk);
  722. >     int ptype = V_ASN1_UNDEF;
  723.
  724.       algobj = OBJ_nid2obj(EVP_PKEY_base_id(pk));