summary |
shortlog |
log |
commit | commitdiff |
tree
raw |
patch |
inline | side by side (from parent 1:
8c79e31)
Saw the error
Fetching journal entries for: palfrey
Fetching journal entry L-867 (create)
Fetching journal comments for: palfrey
*** Error fetching comment meta, possibly not community maintainer?
Traceback (most recent call last):
File "ljdump.py", line 358, in <module>
ljdump(server, username, password, username)
File "ljdump.py", line 244, in ljdump
r.close()
AttributeError: 'dict' object has no attribute 'close'
(notably, this is my personal journal, so missing permissions shouldn't
happen)
This patch handles this weird case (which will probably never now happen
again)
Signed-off-by: Greg Hewgill <greg@hewgill.com>
print "*** Error fetching comment meta, possibly not community maintainer?"
break
finally:
print "*** Error fetching comment meta, possibly not community maintainer?"
break
finally:
+ try:
+ r.close()
+ except AttributeError: # r is sometimes a dict for unknown reasons
+ pass
for c in meta.getElementsByTagName("comment"):
id = int(c.getAttribute("id"))
metacache[id] = {
for c in meta.getElementsByTagName("comment"):
id = int(c.getAttribute("id"))
metacache[id] = {